Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoaderClient.h
diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h
index 236a3d2311eb4ab2313062b0efb5504b50a85792..31e86db05602be7c2b01bc691134aa84165ff714 100644
--- a/Source/core/loader/FrameLoaderClient.h
+++ b/Source/core/loader/FrameLoaderClient.h
@@ -86,6 +86,7 @@ class FetchRequest;
class FrameLoaderClient {
public:
+ enum PluginLoadType { PluginLoadRequiresRenderer, PluginLoadWithoutRenderer};
virtual ~FrameLoaderClient() { }
virtual void frameLoaderDestroyed() = 0;
@@ -164,7 +165,8 @@ class FetchRequest;
virtual void transitionToCommittedForNewPage() = 0;
virtual PassRefPtr<Frame> createFrame(const KURL&, const String& name, const String& referrer, HTMLFrameOwnerElement*) = 0;
- virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool loadManually) = 0;
+ virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const = 0;
+ virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool loadManually, PluginLoadType = PluginLoadRequiresRenderer) = 0;
virtual PassRefPtr<Widget> createJavaAppletWidget(const IntSize&, HTMLAppletElement*, const KURL& baseURL, const Vector<String>& paramNames, const Vector<String>& paramValues) = 0;

Powered by Google App Engine
This is Rietveld 408576698