Source/core/html/HTMLFrameElementBase.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameElementBase.cpp

diff --git a/Source/core/html/HTMLFrameElementBase.cpp b/Source/core/html/HTMLFrameElementBase.cpp

index fc6bfb98c359fdc672ec04e415689bc1cca438c5..f1149c4f18eafc1ae74acacac8b94c25f1cdd4f9 100644

--- a/Source/core/html/HTMLFrameElementBase.cpp

+++ b/Source/core/html/HTMLFrameElementBase.cpp

@@ -163,9 +163,9 @@ void HTMLFrameElementBase::attach(const AttachContext& context)

{

HTMLFrameOwnerElement::attach(context);

- if (RenderPart* part = renderPart()) {

+ if (renderPart()) {

if (Frame* frame = contentFrame())

- part->setWidget(frame->view());

+ setWidget(frame->view());

}