Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix mac compile issue. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index 87a5c3eae9805168a18058f3e93800e5f7cd2ac4..dbd0fdf935b775ab5e50c9f9e6e7e196d383c01c 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -100,6 +100,8 @@ void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicSt
m_serviceType = m_serviceType.left(pos);
if (renderer())
setNeedsWidgetUpdate(true);
+ else
+ requestPluginCreationWithoutRendererIfPossible();
} else if (name == dataAttr) {
m_url = stripLeadingAndTrailingHTMLSpaces(value);
if (renderer()) {
@@ -439,7 +441,7 @@ bool HTMLObjectElement::appendFormData(FormDataList& encoding, bool)
if (name().isEmpty())
return false;
- Widget* widget = pluginWidget();
+ Widget* widget = this->widget();
if (!widget || !widget->isPluginView())
return false;
String value;

Powered by Google App Engine
This is Rietveld 408576698