Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index a6c41a64410c84aff12b9259375fbd5e85e31dd5..3298d236ce8544be12f66dc4175f374b8cc72219 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -600,6 +600,14 @@ PassRefPtr<Frame> FrameLoaderClientImpl::createFrame(
return m_webFrame->createChildFrame(frameRequest, ownerElement);
}
+bool FrameLoaderClientImpl::canCreatePluginWithoutRenderer(const String& mimeType) const
+{
+ if (!m_webFrame->client())
+ return false;
+
+ return m_webFrame->client()->canCreatePluginWithoutRenderer(mimeType);
+}
+
PassRefPtr<Widget> FrameLoaderClientImpl::createPlugin(
const IntSize& size, // FIXME: how do we use this?
HTMLPlugInElement* element,
@@ -607,7 +615,8 @@ PassRefPtr<Widget> FrameLoaderClientImpl::createPlugin(
const Vector<String>& paramNames,
const Vector<String>& paramValues,
const String& mimeType,
- bool loadManually)
+ bool loadManually,
+ PluginLoadType loadType)
{
if (!m_webFrame->client())
return 0;
@@ -631,7 +640,7 @@ PassRefPtr<Widget> FrameLoaderClientImpl::createPlugin(
return 0;
// The element might have been removed during plugin initialization!
- if (!element->renderer())
+ if (!element->renderer() && loadType != PluginLoadWithoutRenderer)
return 0;
return container;

Powered by Google App Engine
This is Rietveld 408576698