Source/testing/runner/WebTestProxy.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/testing/runner/WebTestProxy.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/testing/runner/WebTestProxy.cpp

diff --git a/Source/testing/runner/WebTestProxy.cpp b/Source/testing/runner/WebTestProxy.cpp

index a5a9bede61b6bda69611d7ba3c7f4a1c74ecec51..2c9134a098b5c61bc50d1f06dfb085142d3ad122 100644

--- a/Source/testing/runner/WebTestProxy.cpp

+++ b/Source/testing/runner/WebTestProxy.cpp

@@ -923,7 +923,7 @@ bool WebTestProxyBase::createView(WebFrame*, const WebURLRequest& request, const

WebPlugin* WebTestProxyBase::createPlugin(WebFrame* frame, const WebPluginParams& params)

{

- if (params.mimeType == TestPlugin::mimeType())

+ if (params.mimeType.utf8().find(TestPlugin::mimeType().utf8(), 0) != std::string::npos)

return TestPlugin::create(frame, params, m_delegate);

return 0;

}