Source/core/html/HTMLEmbedElement.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLEmbedElement.cpp

diff --git a/Source/core/html/HTMLEmbedElement.cpp b/Source/core/html/HTMLEmbedElement.cpp

index fd2a83365c76c4bb72aa288175f98de700abbfc3..1769896355507cc6e66a337e8dbe6e5879e2dddc 100644

--- a/Source/core/html/HTMLEmbedElement.cpp

+++ b/Source/core/html/HTMLEmbedElement.cpp

@@ -96,6 +96,7 @@ void HTMLEmbedElement::parseAttribute(const QualifiedName& name, const AtomicStr

size_t pos = m_serviceType.find(";");

if (pos != kNotFound)

m_serviceType = m_serviceType.left(pos);

+ requestPluginCreationWithoutRendererIfPossible();

} else if (name == codeAttr) {

m_url = stripLeadingAndTrailingHTMLSpaces(value);

} else if (name == srcAttr) {