Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/frame/FrameView.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/plugins/plugin-persists.html ('K') | « Source/core/frame/Frame.cpp ('k') | Source/core/html/HTMLAppletElement.cpp » ('j') | Source/core/html/HTMLFrameOwnerElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index d47a08e4179105aab5978e042e456a8106a10f6f..7dedabb602e4f243855b40268b06f1fbbe656f52 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -240,9 +240,9 @@ FrameView::~FrameView()
ASSERT(m_frame);
ASSERT(m_frame->view() != this || !m_frame->contentRenderer());
- RenderPart* renderer = m_frame->ownerRenderer();
- if (renderer && renderer->widget() == this)
- renderer->setWidget(0);
+ HTMLFrameOwnerElement* ownerElement = m_frame->ownerElement();
+ if (ownerElement && ownerElement->widget() == this)
+ ownerElement->setWidget(0);
}
void FrameView::reset()
« LayoutTests/plugins/plugin-persists.html ('K') | « Source/core/frame/Frame.cpp ('k') | Source/core/html/HTMLAppletElement.cpp » ('j') | Source/core/html/HTMLFrameOwnerElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698