Source/core/dom/Document.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(487)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/dom/Document.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« LayoutTests/plugins/plugin-persists.html ('K') | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/html/HTMLFrameOwnerElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 20ee2edf2273cb5b7fb53b7b724313f73a2807f8..b847e2b896c8a71e4ed6474ce9937d2963a23992 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -163,7 +163,6 @@

#include "core/rendering/FastTextAutosizer.h"

#include "core/rendering/HitTestResult.h"

#include "core/rendering/RenderView.h"

-#include "core/rendering/RenderWidget.h"

#include "core/rendering/TextAutosizer.h"

#include "core/svg/SVGDocumentExtensions.h"

#include "core/svg/SVGStyleElement.h"

@@ -1677,7 +1676,7 @@ void Document::recalcStyle(StyleRecalcChange change)

{

PostAttachCallbacks::SuspendScope suspendPostAttachCallbacks;

- RenderWidget::UpdateSuspendScope suspendWidgetHierarchyUpdates;

+ HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;

FrameView::DeferredRepaintScope deferRepaints(*view());

TemporaryChange<bool> changeInStyleRecalc(m_inStyleRecalc, true);

« LayoutTests/plugins/plugin-persists.html ('K') | « Source/core/dom/ContainerNode.cpp ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/html/HTMLFrameOwnerElement.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698