Source/web/WebHelperPluginImpl.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revised method for widget lifetime management. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebHelperPluginImpl.cpp

diff --git a/Source/web/WebHelperPluginImpl.cpp b/Source/web/WebHelperPluginImpl.cpp

index 5f6e7bb45a294f899b88f4a11d1057d6a6061c56..2dbd7b3942c2bff81627dd7ef3fcaa0e0ac4bbae 100644

--- a/Source/web/WebHelperPluginImpl.cpp

+++ b/Source/web/WebHelperPluginImpl.cpp

@@ -193,7 +193,7 @@ WebPlugin* WebHelperPluginImpl::getPlugin()

return 0;

Node* node = objectElements->item(0);

ASSERT(node->hasTagName(WebCore::HTMLNames::objectTag));

- WebCore::Widget* widget = toHTMLPlugInElement(node)->pluginWidget();

+ WebCore::Widget* widget = toHTMLPlugInElement(node)->widget();

if (!widget)

return 0;

WebPlugin* plugin = toPluginContainerImpl(widget)->plugin();