Source/web/FrameLoaderClientImpl.h - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Don't store plugin (widget) pointer in RenderWidget. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.h

diff --git a/Source/web/FrameLoaderClientImpl.h b/Source/web/FrameLoaderClientImpl.h

index c1c4d0eca5dbfa42a164ede5d14d1330444791e5..1e8039fc55920a199bddd176d9ea55ffc10dce4f 100644

--- a/Source/web/FrameLoaderClientImpl.h

+++ b/Source/web/FrameLoaderClientImpl.h

@@ -114,10 +114,11 @@ public:

virtual WTF::String doNotTrackValue();

virtual void transitionToCommittedForNewPage();

virtual PassRefPtr<WebCore::Frame> createFrame(const WebCore::KURL&, const WTF::String& name, const WTF::String& referrer, WebCore::HTMLFrameOwnerElement*);

+ virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const;

virtual PassRefPtr<WebCore::Widget> createPlugin(

const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KURL&,

const Vector<WTF::String>&, const Vector<WTF::String>&,

- const WTF::String&, bool loadManually);

+ const WTF::String&, bool loadManually, bool loadWithoutRenderer = false);

virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget(

const WebCore::IntSize&,

WebCore::HTMLAppletElement*,

« Source/core/rendering/RenderWidget.cpp ('K') | « Source/platform/Widget.h ('k') | Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »