LayoutTests/plugins/plugin-persists.html - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/plugins/plugin-persists.html

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add tests, make plugin creation synchronous. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/plugins/can-create-without-renderer.html ('K') | « LayoutTests/plugins/can-create-without-renderer-expected.txt ('k') | LayoutTests/plugins/plugin-persists-expected.txt » ('j') | Source/core/html/HTMLFrameOwnerElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <style>

	4 #plugin {

	5 width: 150px;

	6 height: 150px;

	7 }

	8 </style>

	9 </head>

	10

	11 <body>

	12 <embed id="plugin" type="application/x-webkit-test-webplugin-persistent" primiti ve="triangle" background-color="green" primitive-color="blue"></embed>

	13 <div>Each line below should start with 'Pass':</div>

	14 <div id="result1"></div>

	15 <div id="result2"></div>

	16 <script>

	17

	18 if (!window.testRunner) {

	19 document.write("This test does not work in manual mode.");

	20 } else {

	21 testRunner.dumpAsText();

	22 testRunner.waitUntilDone();

	23

	24 if (plugin.isPersistent)

	25 result1.innerHTML = "Pass: plugin identifies itself as persistent.";

	26 else

	27 result1.innerHTML = "Fail: plugin identifies itself as not-persistent. ";

	28

	29 // Verify that the plugin is not destroyed.

	30 plugin.setAttribute("display", "none");

	31 // Force synchronous style recalc.

	32 document.body.offsetTop;
	eseidel 2013/12/12 20:40:13 I might use plugin.offsetTop to make sure we don't I might use plugin.offsetTop to make sure we don't optimize skipping layout for that element. wjmaclean 2013/12/12 22:31:15 Thanks, will give that a try. Show quoted text On 2013/12/12 20:40:13, eseidel wrote: > I might use plugin.offsetTop to make sure we don't optimize skipping layout for > that element. Thanks, will give that a try.
	33

	34 window.setTimeout(function () {

	35 if (plugin.instanceId == 1)

	36 result2.innerHTML = "Pass: plugin is persisting.";

	37 else

	38 result2.innerHTML = "Fail: plugin failed to persist.";

	39 testRunner.notifyDone();

	40 }, 50);

	41 }

	42

	43 </script>

	44 </body>

	45 </html>

OLD	NEW