Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/core/html/HTMLObjectElement.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Handle shared-renderer case. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLFrameOwnerElement.cpp ('k') | Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicSt ring& value) 91 void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicSt ring& value)
92 { 92 {
93 if (name == formAttr) 93 if (name == formAttr)
94 formAttributeChanged(); 94 formAttributeChanged();
95 else if (name == typeAttr) { 95 else if (name == typeAttr) {
96 m_serviceType = value.lower(); 96 m_serviceType = value.lower();
97 size_t pos = m_serviceType.find(";"); 97 size_t pos = m_serviceType.find(";");
98 if (pos != kNotFound) 98 if (pos != kNotFound)
99 m_serviceType = m_serviceType.left(pos); 99 m_serviceType = m_serviceType.left(pos);
100 // FIXME: What is the right thing to do here? Should we supress the
101 // reload stuff when a persistable widget-type is specified?
100 reloadPluginOnAttributeChange(name); 102 reloadPluginOnAttributeChange(name);
103 if (!renderer())
104 requestPluginCreationWithoutRendererIfPossible();
101 } else if (name == dataAttr) { 105 } else if (name == dataAttr) {
102 m_url = stripLeadingAndTrailingHTMLSpaces(value); 106 m_url = stripLeadingAndTrailingHTMLSpaces(value);
103 if (renderer() && isImageType()) { 107 if (renderer() && isImageType()) {
104 setNeedsWidgetUpdate(true); 108 setNeedsWidgetUpdate(true);
105 if (!m_imageLoader) 109 if (!m_imageLoader)
106 m_imageLoader = adoptPtr(new HTMLImageLoader(this)); 110 m_imageLoader = adoptPtr(new HTMLImageLoader(this));
107 m_imageLoader->updateFromElementIgnoringPreviousError(); 111 m_imageLoader->updateFromElementIgnoringPreviousError();
108 } else { 112 } else {
109 reloadPluginOnAttributeChange(name); 113 reloadPluginOnAttributeChange(name);
110 } 114 }
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 { 484 {
481 return fastHasAttribute(usemapAttr); 485 return fastHasAttribute(usemapAttr);
482 } 486 }
483 487
484 bool HTMLObjectElement::useFallbackContent() const 488 bool HTMLObjectElement::useFallbackContent() const
485 { 489 {
486 return HTMLPlugInElement::useFallbackContent() || m_useFallbackContent; 490 return HTMLPlugInElement::useFallbackContent() || m_useFallbackContent;
487 } 491 }
488 492
489 } 493 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFrameOwnerElement.cpp ('k') | Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698