Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: trunk/src/chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 23618018: Revert 220402 "Improve <webview> autosize:" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
===================================================================
--- trunk/src/chrome/test/data/extensions/platform_apps/web_view/shim/main.js (revision 220583)
+++ trunk/src/chrome/test/data/extensions/platform_apps/web_view/shim/main.js (working copy)
@@ -170,8 +170,6 @@
var step = 1;
var sizeChangeHandler = function(e) {
- window.console.log('sizeChangeHandler, new: ' +
- e.newWidth + ' X ' + e.newHeight);
switch (step) {
case 1:
// Expect 300x200.
@@ -186,13 +184,14 @@
embedder.test.assertEq(640, e.newWidth);
// Tests when minwidth > maxwidth, minwidth = maxwidth.
+ webview.maxheight = null;
webview.minwidth = 800;
+ webview.minheight = 800;
break;
case 3:
- // Expect 700X?
+ // Expect 700X480
embedder.test.assertEq(700, e.newWidth);
- embedder.test.assertTrue(e.newHeight >= 200);
- embedder.test.assertTrue(e.newHeight <= 600);
+ embedder.test.assertEq(480, e.newHeight);
// Remove maxwidth and make sure the size returns to plugin size.
webview.removeAttribute('maxwidth');
@@ -200,8 +199,7 @@
case 4:
// Expect original size, 640x480.
embedder.test.assertEq(640, e.newWidth);
- embedder.test.assertTrue(e.newHeight >= 200);
- embedder.test.assertTrue(e.newHeight <= 600);
+ embedder.test.assertEq(480, e.newHeight);
embedder.test.succeed();
break;

Powered by Google App Engine
This is Rietveld 408576698