Suppressing exceptions in Dartium's dart:js usage

pkg/polymer/lib/polymer_element.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library polymer.polymer_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:mirrors';
 import 'dart:js' as dartJs;
@@ skipping 158 matching lines @@
       return new _PolymerBinding(this, name, model, path, propObserver);
     }
     return super.createBinding(name, model, path);
   }
 
   /**
    * Using Polymer's platform/src/ShadowCSS.js passing the style tag's content.
    */
   void _shimCss(ShadowRoot root, String localName, String extendsName) {
     // TODO(terry): Need to detect if ShadowCSS.js has been loaded.  Under
     //              Dartium this wouldn't exist.  However, dart:js isn't robust

[blois, 2013/08/27 20:29:30]

Not sure if there are additional changes I should do to this code for this CL.

     //              to use to detect in both Dartium and dart2js if Platform is
-    //              defined. Instead in Dartium it throws an exception but in
-    //              dart2js it works enough to know if Platform is defined (just
-    //              can't be used for further derefs).  This bug is described
+    //              defined.  This bug is described in
     //              https://code.google.com/p/dart/issues/detail?id=12548
     //              When fixed only use dart:js.  This is necessary under
     //              Dartium (no compile) we want to run w/o the JS polyfill.
-    try {
-      if (dartJs.context["Platform"] == null) { return; }
-    } on NoSuchMethodError catch (e) { return; }
+    if (dartJs.context == null || !dartJs.context.hasProperty('Platform')) {
+      return;

[terry, 2013/08/27 23:30:09]

Nice to eliminate the try/catch.

+    }
 
     var platform = js.context["Platform"];
     if (platform == null) return;
     var shadowCss = platform.ShadowCSS;
     if (shadowCss == null) return;
 
     // TODO(terry): Remove calls to shimShadowDOMStyling2 and replace with
     //              shimShadowDOMStyling when we support unwrapping dart:html
     //              Element to a JS DOM node.
     var shimShadowDOMStyling2 = shadowCss.shimShadowDOMStyling2;
@@ skipping 357 matching lines @@
   'onKeyMessage': MediaElement.keyMessageEvent,
   'onNeedKey': MediaElement.needKeyEvent,
   'onWebGlContextLost': CanvasElement.webGlContextLostEvent,
   'onWebGlContextRestored': CanvasElement.webGlContextRestoredEvent,
   'onPointerLockChange': Document.pointerLockChangeEvent,
   'onPointerLockError': Document.pointerLockErrorEvent,
   'onReadyStateChange': Document.readyStateChangeEvent,
   'onSelectionChange': Document.selectionChangeEvent,
   'onSecurityPolicyViolation': Document.securityPolicyViolationEvent,
 };