Issue 23618004: Remove less then useful configs from bench_pictures runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23618004: Remove less then useful configs from bench_pictures runs (Closed)

Created:
7 years, 3 months ago by robertphillips

Modified:
7 years, 3 months ago

Reviewers:
bsalomon, mtklein, benchen, reed1

CC:
borenet, epoger, rmistry, benchen, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/tools/

Visibility:
Public.

More Reviews

Description

As a start I propose removing the 1024x256 and 1024x64 configs.

Patch Set 2 : Reduce multithreaded tests to only use 4 thread configuration #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	bench_pictures.cfg	View	1	2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mtklein

https://codereview.chromium.org/23618004/diff/1/bench_pictures.cfg File bench_pictures.cfg (right): https://codereview.chromium.org/23618004/diff/1/bench_pictures.cfg#newcode48 bench_pictures.cfg:48: MultiThreadTileConfig(2, DEFAULT_TILE_X, DEFAULT_TILE_Y), No real extra benefit to have ...

7 years, 3 months ago (2013-08-27 19:31:47 UTC) #2

mtklein

On 2013/08/27 19:50:23, robertphillips wrote: > Reduced multithreaded configurations lgtm

7 years, 3 months ago (2013-08-27 20:57:11 UTC) #5

benchen

LGTM. Then I can remove the deprecated data from the database so the dashboard is ...

7 years, 3 months ago (2013-08-27 21:03:03 UTC) #6

Message was sent while issue was closed.

committed as r10973

Expand Messages | Collapse Messages

Issue 23618004: Remove less then useful configs from bench_pictures runs (Closed)

Description

Patch Set 1 #

Patch Set 2 : Reduce multithreaded tests to only use 4 thread configuration #

Messages