Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23618002: Hydrogenisation of binops (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Hydrogenisation of binops superseeded by: https://codereview.chromium.org/24072013/

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1494 lines, -4085 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 chunks +12 lines, -988 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 5 chunks +7 lines, -15 lines 0 comments Download
M src/arm/lithium-arm.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 6 chunks +53 lines, -71 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 chunks +13 lines, -9 lines 0 comments Download
M src/ast.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 5 chunks +142 lines, -136 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +280 lines, -88 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/hydrogen.h View 1 3 chunks +27 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 6 chunks +199 lines, -75 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +28 lines, -13 lines 0 comments Download
M src/ia32/assembler-ia32.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 7 chunks +16 lines, -1448 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 5 chunks +5 lines, -11 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 7 chunks +19 lines, -18 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 3 chunks +2 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 8 chunks +43 lines, -75 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ic.h View 1 3 chunks +6 lines, -13 lines 0 comments Download
M src/ic.cc View 1 3 chunks +86 lines, -242 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/type-info.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/type-info.cc View 2 chunks +21 lines, -31 lines 0 comments Download
M src/types.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/typing.cc View 2 chunks +13 lines, -1 line 0 comments Download
M src/v8-counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 6 chunks +13 lines, -728 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 5 chunks +7 lines, -15 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 8 chunks +41 lines, -68 lines 0 comments Download
A test/mjsunit/regress/regress-binop.js View 1 chunk +168 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-binop-nosse2.js View 1 chunk +168 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oliv
7 years, 3 months ago (2013-09-12 13:46:50 UTC) #1
Sven Panne
7 years, 3 months ago (2013-09-13 13:00:17 UTC) #2 
Actually this CL seems to contain several separate changes, and I would really
like to see them separately, including benchmark results. We should probably
discuss this offline...

Powered by Google App Engine
This is Rietveld 408576698