Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2361773002: [turbofan] Bailout for call sites w/o feedback. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Bailout for call sites w/o feedback. If a JSCallFunction node doesn't have any callee information, either from feedback taken on input nodes, i.e. on property loads, or from the CallIC, we insert a soft deoptimization exit instead. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/b63de989dbd7236b9b7750d2edb4dd85eecb9036 Cr-Commit-Position: refs/heads/master@{#39619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M src/compiler/js-call-reducer.h View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
Hey Jaro, Here's the baby. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-09-22 09:27:03 UTC) #3
Jarin
lgtm
4 years, 2 months ago (2016-09-22 09:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361773002/1
4 years, 2 months ago (2016-09-22 09:30:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 10:01:21 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 10:02:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b63de989dbd7236b9b7750d2edb4dd85eecb9036
Cr-Commit-Position: refs/heads/master@{#39619}

Powered by Google App Engine
This is Rietveld 408576698