Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2361763002: orderfile: Don't report failure when a few symbol pairs are misordered. (Closed)

Created:
4 years, 3 months ago by Benoit L
Modified:
4 years, 3 months ago
Reviewers:
pasko
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

orderfile: Don't report failure when a few symbol pairs are misordered. A few misordered pairs are not going to affect startup performance. Making this a warning only, as it broke the official builders. This is not a fix, unfortunately. This is the second bump in the number of tolerated misordered symbols, and as long as it stays low, there is no expected performance impact. BUG=645460 Committed: https://crrev.com/2b0d382c838e851d1b8511f907402f782c80df3d Cr-Commit-Position: refs/heads/master@{#420296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/cygprofile/check_orderfile.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Benoit L
4 years, 3 months ago (2016-09-22 08:37:41 UTC) #2
pasko
lgtm, thanks! I cannot see a an obvious reason why content::LayeredResourceHandler::OnWillRead would be misordered with ...
4 years, 3 months ago (2016-09-22 09:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361763002/1
4 years, 3 months ago (2016-09-22 09:33:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 10:04:17 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 10:05:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b0d382c838e851d1b8511f907402f782c80df3d
Cr-Commit-Position: refs/heads/master@{#420296}

Powered by Google App Engine
This is Rietveld 408576698