Adding @keyframes rules only affects TreeScope plus host.

Adding @keyframes rules only affects TreeScope plus host.

@keyframes rules may apply to animations in the same TreeScope as the
rule and the host element if the TreeScope is a shadow tree. Instead of
invalidating all keyframe animations or recalculating every element in
the document, limit such changes to the relevant TreeScopes.

Currently, this doesn't have an effect since analyzed style update only
happens in the document TreeScope, but that will change with RuleSet
invalidation for crbug.com/567021

R=alancutter@chromium.org,suzyh@chromium.org
BUG=567021
Committed: https://crrev.com/5592758d33ac5041761a5aeab86258c2dcea39c5
Cr-Commit-Position: refs/heads/master@{#421781}

[rune, 2016-09-22 22:33:31]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:34:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 22:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:36:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rune, 2016-09-22 22:44:36]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-09-22 22:52:01]

ptal

[suzyh_UTC10 (ex-contributor), 2016-09-22 23:55:48]

I don't have a good understanding of the context for this change so I'll defer
to Alan for the core/animation approval. I had a look at the change and have no
comments to add.

[commit-bot: I haz the power, 2016-09-23 00:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 00:47:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2016-09-27 06:49:50]

core/animation lgtm with nit.

https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/Animation.cpp (right):

https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/Animation.cpp:1101: }
Nit: Move this static method to core/animation/css/CSSAnimations.h.

[suzyh_UTC10 (ex-contributor), 2016-09-28 00:58:43]

suzyh@chromium.org changed reviewers:
- suzyh@chromium.org

[rune, 2016-09-28 21:35:57]

Doh. Forgot to publish.

https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/Animation.cpp (right):

https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/Animation.cpp:1101: }
On 2016/09/27 at 06:49:50, alancutter wrote:
> Nit: Move this static method to core/animation/css/CSSAnimations.h.

Did you mean like patch set 4?

[rune, 2016-09-28 21:50:52]

rune@opera.com changed reviewers:
+ timloh@chromium.org

[rune, 2016-09-28 21:50:53]

timloh@: could you take a look at the non-animation/ changes? It's basically
about moving the unresolved keyframes flag from StyleEngine to a per
ScopedStyleResolver flag. @keyframes rules apply to elements in the same
(shadow) tree as the stylesheet or the shadow tree's host element.

[Timothy Loh, 2016-09-29 04:25:46]

On 2016/09/28 21:50:53, rune wrote:
> timloh@: could you take a look at the non-animation/ changes? It's basically
> about moving the unresolved keyframes flag from StyleEngine to a per
> ScopedStyleResolver flag. @keyframes rules apply to elements in the same
> (shadow) tree as the stylesheet or the shadow tree's host element.

lgtm

[alancutter (OOO until 2018), 2016-09-29 06:22:12]

On 2016/09/28 at 21:35:57, rune wrote:
> Doh. Forgot to publish.
> 
>
https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/Animation.cpp (right):
> 
>
https://codereview.chromium.org/2361733004/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/Animation.cpp:1101: }
> On 2016/09/27 at 06:49:50, alancutter wrote:
> > Nit: Move this static method to core/animation/css/CSSAnimations.h.
> 
> Did you mean like patch set 4?

Yes, this is satisfactory.
I will probably end up moving invalidateKeyframeEffects out of the animation
engine entirely and into CSSAnimations instead. For this patch I just didn't
want the concept of @keyframes rules being added to the core animation engine.

[rune, 2016-09-29 07:19:09]

The CQ bit was checked by rune@opera.com

[rune, 2016-09-29 07:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2361733004/#ps60001
(title: "Moved scope check to CSSAnimations")

[commit-bot: I haz the power, 2016-09-29 07:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 08:48:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-29 08:50:43]

Description was changed from

==========
Adding @keyframes rules only affects TreeScope plus host.

@keyframes rules may apply to animations in the same TreeScope as the
rule and the host element if the TreeScope is a shadow tree. Instead of
invalidating all keyframe animations or recalculating every element in
the document, limit such changes to the relevant TreeScopes.

Currently, this doesn't have an effect since analyzed style update only
happens in the document TreeScope, but that will change with RuleSet
invalidation for crbug.com/567021

R=alancutter@chromium.org,suzyh@chromium.org
BUG=567021
==========

to

==========
Adding @keyframes rules only affects TreeScope plus host.

@keyframes rules may apply to animations in the same TreeScope as the
rule and the host element if the TreeScope is a shadow tree. Instead of
invalidating all keyframe animations or recalculating every element in
the document, limit such changes to the relevant TreeScopes.

Currently, this doesn't have an effect since analyzed style update only
happens in the document TreeScope, but that will change with RuleSet
invalidation for crbug.com/567021

R=alancutter@chromium.org,suzyh@chromium.org
BUG=567021

Committed: https://crrev.com/5592758d33ac5041761a5aeab86258c2dcea39c5
Cr-Commit-Position: refs/heads/master@{#421781}
==========

[commit-bot: I haz the power, 2016-09-29 08:50:44]

Patchset 4 (id:??) landed as
https://crrev.com/5592758d33ac5041761a5aeab86258c2dcea39c5
Cr-Commit-Position: refs/heads/master@{#421781}