Issue 236173003: Merge 261645 "Enable maximize mode when keyboard is open past 18..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236173003: Merge 261645 "Enable maximize mode when keyboard is open past 18..." (Closed)

Created:
6 years, 8 months ago by flackr

Modified:
6 years, 8 months ago

Reviewers:
flackr

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

Merge 261645 "Enable maximize mode when keyboard is open past 18..." > Enable maximize mode when keyboard is open past 180 degrees. > > BUG=342911 > TEST=MaximizeModeControllerTest.* > TEST=Open keyboard past 180 degrees, device should auto-enter maximize mode. > > Review URL: https://codereview.chromium.org/197883011 TBR=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263406

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, --3 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ash/shell.h	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	ash/shell.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
A +	ash/wm/maximize_mode/maximize_mode_controller.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ash/wm/maximize_mode/maximize_mode_controller.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ash/wm/maximize_mode/maximize_mode_controller_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r263406.