Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 23617008: Added Mac to list of supported platforms for chrome.notifications. (Closed)

Created:
7 years, 3 months ago by Andy
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/common/extensions/docs/templates/intros/notifications.html View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andy
7 years, 3 months ago (2013-08-28 21:40:04 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html File chrome/common/extensions/docs/templates/intros/notifications.html (right): https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html#newcode3 chrome/common/extensions/docs/templates/intros/notifications.html:3: Currently this API only works on ChromeOS, Windows, and ...
7 years, 3 months ago (2013-08-28 21:43:11 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html File chrome/common/extensions/docs/templates/intros/notifications.html (right): https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html#newcode3 chrome/common/extensions/docs/templates/intros/notifications.html:3: Currently this API only works on ChromeOS, Windows, and ...
7 years, 3 months ago (2013-08-28 21:45:12 UTC) #3
somast1
On 2013/08/28 21:45:12, kalman wrote: > https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html > File chrome/common/extensions/docs/templates/intros/notifications.html (right): > > https://codereview.chromium.org/23617008/diff/1/chrome/common/extensions/docs/templates/intros/notifications.html#newcode3 > ...
7 years, 3 months ago (2013-08-28 22:25:27 UTC) #4
Andy
On 2013/08/28 22:25:27, somast1 wrote: > > I'd just say 'This API is currently available ...
7 years, 3 months ago (2013-08-28 23:00:42 UTC) #5
Andy
PTAL: https://chrome-apps-doc.appspot.com/_patch/23617008/apps/notifications.html
7 years, 3 months ago (2013-08-28 23:09:40 UTC) #6
not at google - send to devlin
lgtm
7 years, 3 months ago (2013-08-28 23:14:34 UTC) #7
Dmitry Titov
lgtm, thanks!
7 years, 3 months ago (2013-08-28 23:59:33 UTC) #8
Andy
7 years, 3 months ago (2013-08-29 23:08:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r220419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698