Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2361693002: Remove reference to base/memory/ref_counted.cc from GN bootstrap. (Closed)

Created:
4 years, 2 months ago by Dirk Pranke
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove reference to base/memory/ref_counted.cc from GN bootstrap. R=brettw@chromium.org, phajdan.jr@chromium.org Committed: https://crrev.com/27933010d920c22d7e536d100099223152b3c7c6 Cr-Commit-Position: refs/heads/master@{#420510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
4 years, 2 months ago (2016-09-22 23:05:21 UTC) #1
brettw
lgtm
4 years, 2 months ago (2016-09-22 23:28:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361693002/1
4 years, 2 months ago (2016-09-22 23:53:45 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 00:06:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27933010d920c22d7e536d100099223152b3c7c6
Cr-Commit-Position: refs/heads/master@{#420510}

Powered by Google App Engine
This is Rietveld 408576698