Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2361653002: Omnibox Metrics - Remove Percent Match Histograms (Closed)

Created:
4 years, 3 months ago by Mark P
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox Metrics - Remove Percent Match Histograms BUG=627747 Committed: https://crrev.com/1f3d5ea1442e106a58001521e412b75da5030e61 Cr-Commit-Position: refs/heads/master@{#420410}

Patch Set 1 #

Patch Set 2 : more polish of histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -52 lines) Patch
M components/omnibox/browser/omnibox_edit_model.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 5 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Mark P
I recently rediscovered this histograms. Here's my reaction. :-) Let me know what you think. ...
4 years, 3 months ago (2016-09-21 22:32:52 UTC) #3
Marc Treib
LGTM, thanks for the cleanup!
4 years, 3 months ago (2016-09-22 09:59:20 UTC) #4
Mark P
+rkaplow for official independent metrics review --mark
4 years, 3 months ago (2016-09-22 17:13:45 UTC) #6
rkaplow
lgtm
4 years, 3 months ago (2016-09-22 17:15:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361653002/20001
4 years, 3 months ago (2016-09-22 17:20:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 18:55:24 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:59:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f3d5ea1442e106a58001521e412b75da5030e61
Cr-Commit-Position: refs/heads/master@{#420410}

Powered by Google App Engine
This is Rietveld 408576698