Control distillability with command-line flag

Control distillability with command-line flag

BUG=646384
Committed: https://crrev.com/a6b9e17dc1dcac1da44f723445dd4201bc1e0a5f
Cr-Commit-Position: refs/heads/master@{#420617}

[mdjones, 2016-09-22 00:28:06]

mdjones@chromium.org changed reviewers:
+ thestig@chromium.org, wychen@chromium.org

[mdjones, 2016-09-22 00:28:06]

ptal

[mdjones, 2016-09-22 00:28:07]

ptal

[wychen, 2016-09-22 19:21:29]

LGTM.

thestig@, are there any conflicts with your removal of dom distiller on desktop?
The binary size of distillability shouldn't be too big, so we could keep it
while removing distiller code.

[Lei Zhang, 2016-09-23 01:33:26]

On 2016/09/22 19:21:29, wychen wrote:
> thestig@, are there any conflicts with your removal of dom distiller on
desktop?
> The binary size of distillability shouldn't be too big, so we could keep it
> while removing distiller code.

No. I just did a quick and dirty experiment. I'm not trying to remove dom
distiller from desktop, but if someone else wants to, please do.

[Lei Zhang, 2016-09-23 01:34:31]

lgtm

https://codereview.chromium.org/2361643004/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/dom_distiller_switches.h (right):

https://codereview.chromium.org/2361643004/diff/1/components/dom_distiller/co...
components/dom_distiller/core/dom_distiller_switches.h:27: extern const char
kEnableDistillabilityService[];
Alphaetical order here and in the .cc file?

[mdjones, 2016-09-23 15:38:06]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-09-23 15:38:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, wychen@chromium.org
Link to the patchset: https://codereview.chromium.org/2361643004/#ps20001
(title: "alphabetical order")

[commit-bot: I haz the power, 2016-09-23 15:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:24:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-23 16:26:42]

Description was changed from

==========
Control distillability with command-line flag

BUG=646384
==========

to

==========
Control distillability with command-line flag

BUG=646384

Committed: https://crrev.com/a6b9e17dc1dcac1da44f723445dd4201bc1e0a5f
Cr-Commit-Position: refs/heads/master@{#420617}
==========

[commit-bot: I haz the power, 2016-09-23 16:26:43]

Patchset 2 (id:??) landed as
https://crrev.com/a6b9e17dc1dcac1da44f723445dd4201bc1e0a5f
Cr-Commit-Position: refs/heads/master@{#420617}