Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 236163006: Reland "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." (Closed)

Created:
6 years, 8 months ago by Alexandre Rames
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." This was reverted by revision 20187. make -j45 arm64.release.check TESTFLAGS=--time TESTJOBS=mozilla/js1_5/Regress/regress-280769-2 Without the patch: --- Total time: 00:07.039 --- 1 (00:07.016) mozilla/js1_5/Regress/regress-280769-2 2 (00:01.814) mozilla/js1_5/Regress/regress-280769-2 3 (00:01.812) mozilla/js1_5/Regress/regress-280769-2 With the patch: --- Total time: 00:12.252 --- 1 (00:12.226) mozilla/js1_5/Regress/regress-280769-2 2 (00:04.217) mozilla/js1_5/Regress/regress-280769-2 3 (00:04.213) mozilla/js1_5/Regress/regress-280769-2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M src/arm64/regexp-macro-assembler-arm64.cc View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 8 months ago (2014-04-14 12:09:42 UTC) #1
ulan
On 2014/04/14 12:09:42, Alexandre Rames wrote: Do you know how this affects octane/regexp benchmark?
6 years, 8 months ago (2014-04-14 12:15:20 UTC) #2
Alexandre Rames
6 years, 8 months ago (2014-04-14 12:35:57 UTC) #3
On 2014/04/14 12:15:20, ulan wrote:
> On 2014/04/14 12:09:42, Alexandre Rames wrote:
> 
> Do you know how this affects octane/regexp benchmark?

Good point. This shows a ~8% performance penalty, so maybe it is better not to
push it.
I note that I should profile the regexp benchmark once we have 'perf', so I can
check there are no other sites where we would do better without veneers.

Powered by Google App Engine
This is Rietveld 408576698