Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 236163005: Remove call to WebSettings::setEditableLinkBehaviorNeverLive. (Closed)

Created:
6 years, 8 months ago by jbroman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove call to WebSettings::setEditableLinkBehaviorNeverLive. After the corresponding Blink change lands, this behavior will be baked into Blink. Blink CL: https://codereview.chromium.org/236203005/ BUG=362961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/renderer/web_preferences.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
6 years, 8 months ago (2014-04-13 21:40:45 UTC) #1
yosin_UTC9
ACK Thanks for clean up!
6 years, 8 months ago (2014-04-14 02:07:20 UTC) #2
ojan
lgtm
6 years, 8 months ago (2014-04-14 02:11:09 UTC) #3
jbroman
I think this needs a content/ OWNER. Blink patch has landed and rolled into Chromium, ...
6 years, 8 months ago (2014-04-14 15:19:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-15 11:45:16 UTC) #5
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 8 months ago (2014-04-15 14:29:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/236163005/1
6 years, 8 months ago (2014-04-15 14:32:03 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 19:26:47 UTC) #8
Message was sent while issue was closed.
Change committed as 263966

Powered by Google App Engine
This is Rietveld 408576698