Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2381)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: catapult_build/js_checks.py

Issue 2361623007: Add a run_eslint wrapper script (Closed)
Patch Set: Changes based on Ned's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« catapult_build/build_steps.py ('K') | « catapult_build/build_steps.py ('k') | common/eslint/bin/run_eslint » ('j') | common/eslint/bin/run_eslint » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: catapult_build/js_checks.py
diff --git a/catapult_build/js_checks.py b/catapult_build/js_checks.py
index 61a5eeaa56fc72444a8b114fb5d0926fdc59d7a4..ce92406b54d2e6de5b84bc9cce30f7117c844c4a 100644
--- a/catapult_build/js_checks.py
+++ b/catapult_build/js_checks.py
@@ -4,7 +4,7 @@
import re
-from node_runner import node_util
+import eslint
from py_vulcanize import strip_js_comments
from catapult_build import parse_html
@@ -84,7 +84,7 @@ class JSChecker(object):
error_lines += filter(None, [self.ConstCheck(i, line)])
if affected_js_files:
- eslint_output = node_util.RunEslint(
+ eslint_output = eslint.RunEslint(
[f.AbsoluteLocalPath() for f in affected_js_files]).rstrip()
if eslint_output:
« catapult_build/build_steps.py ('K') | « catapult_build/build_steps.py ('k') | common/eslint/bin/run_eslint » ('j') | common/eslint/bin/run_eslint » ('J')

Powered by Google App Engine
This is Rietveld 408576698