Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_unittest.cc
diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc
index b56f17e352f49a8ad205db1bb0308646e217a2e6..ee35e6b3aac0558e0871c45dd7f575f3b7ef3361 100644
--- a/content/browser/devtools/devtools_manager_unittest.cc
+++ b/content/browser/devtools/devtools_manager_unittest.cc
@@ -240,14 +240,13 @@ class TestExternalAgentDelegate: public DevToolsExternalAgentProxyDelegate {
void Detach() override { recordEvent("Detach"); };
- std::string GetType() override { return ""; }
- std::string GetTitle() override { return ""; }
- std::string GetDescription() override { return ""; }
+ std::string GetType() override { return std::string(); }
+ std::string GetTitle() override { return std::string(); }
+ std::string GetDescription() override { return std::string(); }
GURL GetURL() override { return GURL(); }
GURL GetFaviconURL() override { return GURL(); }
-
+ std::string GetFrontendURL() override { return std::string(); }
bool Activate() override { return false; };
- bool Inspect() override { return false; };
void Reload() override { };
bool Close() override { return false; };

Powered by Google App Engine
This is Rietveld 408576698