Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index ab38e58e1d170903768b6b37c96d280b8d7dd8e6..7b554746586444132fc49d7f5d35cddcc1bf74a1 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -77,10 +77,11 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
// ToggleDevToolsWindow().
static void OpenDevToolsWindow(content::WebContents* inspected_web_contents);
- // Open or reveal DevTools window. This window will be undocked.
+ // Open or reveal DevTools window, with no special action. Use |profile| to
+ // open client window in, default to |host|'s profile if none given.
static void OpenDevToolsWindow(
- Profile* profile,
- const scoped_refptr<content::DevToolsAgentHost>& agent_host);
+ scoped_refptr<content::DevToolsAgentHost> host,
+ Profile* profile);
// Perform specified action for current WebContents inside a |browser|.
// This may close currently open DevTools window.
@@ -217,6 +218,10 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
static void AddCreationCallbackForTest(const CreationCallback& callback);
static void RemoveCreationCallbackForTest(const CreationCallback& callback);
+ static void OpenDevToolsWindowForFrame(
+ Profile* profile,
+ const scoped_refptr<content::DevToolsAgentHost>& agent_host);
+
// DevTools lifecycle typically follows this way:
// - Toggle/Open: client call;
// - Create;
@@ -304,6 +309,7 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
// content::DevToolsUIBindings::Delegate overrides
void ActivateWindow() override;
void CloseWindow() override;
+ void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override;
void SetInspectedPageBounds(const gfx::Rect& rect) override;
void InspectElementCompleted() override;
void SetIsDocked(bool is_docked) override;

Powered by Google App Engine
This is Rietveld 408576698