Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 036b1b59995a66c283f0d81ad5e720bea3011175..bcf29e1d78f7c26bc833f5f306bb2563324a4f78 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -195,6 +195,7 @@ class DefaultBindingsDelegate : public DevToolsUIBindings::Delegate {
void ActivateWindow() override;
void CloseWindow() override {}
+ void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override {}
void SetInspectedPageBounds(const gfx::Rect& rect) override {}
void InspectElementCompleted() override {}
void SetIsDocked(bool is_docked) override {}
@@ -812,12 +813,12 @@ void DevToolsUIBindings::PerformActionOnRemotePage(const std::string& page_id,
if (!host)
return;
if (action == kRemotePageActionInspect)
- host->Inspect();
- if (action == kRemotePageActionReload)
+ delegate_->Inspect(host);
+ else if (action == kRemotePageActionReload)
host->Reload();
- if (action == kRemotePageActionActivate)
+ else if (action == kRemotePageActionActivate)
host->Activate();
- if (action == kRemotePageActionClose)
+ else if (action == kRemotePageActionClose)
host->Close();
}

Powered by Google App Engine
This is Rietveld 408576698