Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3221)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
index dd3965e7c4a92244edcbb6d9019cbb088761f219..e72dc3a5206db283ffc6c1663588bbfffea2992b 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
@@ -37,23 +37,7 @@ ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() {
void ChromeDevToolsManagerDelegate::Inspect(
content::DevToolsAgentHost* agent_host) {
- Profile* profile =
- Profile::FromBrowserContext(agent_host->GetBrowserContext());
- if (!profile)
- return;
- std::string type = agent_host->GetType();
- if (type == content::DevToolsAgentHost::kTypeSharedWorker ||
- type == content::DevToolsAgentHost::kTypeServiceWorker) {
- DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host);
- return;
- }
- if (type == content::DevToolsAgentHost::kTypeFrame) {
- DevToolsWindow::OpenDevToolsWindow(profile, agent_host);
- return;
- }
- content::WebContents* web_contents = agent_host->GetWebContents();
- if (web_contents)
- DevToolsWindow::OpenDevToolsWindow(web_contents);
+ DevToolsWindow::OpenDevToolsWindow(agent_host, nullptr);
}
base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(

Powered by Google App Engine
This is Rietveld 408576698