Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5037)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/devtools_manager_delegate_android.cc
diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc
index 6b7f24c272239d25b7d65f629fb7b06990fa7ca1..1f078d8f8cdc55213d39808a6853b9f090764650 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.cc
+++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -85,6 +85,10 @@ class TabProxyDelegate : public content::DevToolsExternalAgentProxyDelegate,
return agent_host_ ? agent_host_->GetFaviconURL() : GURL();
}
+ std::string GetFrontendURL() override {
+ return std::string();
+ }
+
bool Activate() override {
TabModel* model;
int index;
@@ -94,13 +98,6 @@ class TabProxyDelegate : public content::DevToolsExternalAgentProxyDelegate,
return true;
}
- bool Inspect() override {
- MaterializeAgentHost();
- if (agent_host_)
- return agent_host_->Inspect();
- return false;
- }
-
void Reload() override {
MaterializeAgentHost();
if (agent_host_)
@@ -168,10 +165,6 @@ DevToolsManagerDelegateAndroid::DevToolsManagerDelegateAndroid()
DevToolsManagerDelegateAndroid::~DevToolsManagerDelegateAndroid() {
}
-void DevToolsManagerDelegateAndroid::Inspect(
- DevToolsAgentHost* agent_host) {
-}
-
base::DictionaryValue* DevToolsManagerDelegateAndroid::HandleCommand(
DevToolsAgentHost* agent_host,
base::DictionaryValue* command_dict) {

Powered by Google App Engine
This is Rietveld 408576698