android_webview/browser/aw_devtools_manager_delegate.cc - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Side by Side Diff: android_webview/browser/aw_devtools_manager_delegate.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « android_webview/browser/aw_devtools_manager_delegate.h ('k') | chrome/browser/android/devtools_manager_delegate_android.h » ('j') | chrome/browser/android/devtools_manager_delegate_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "android_webview/browser/aw_devtools_manager_delegate.h"	5 #include "android_webview/browser/aw_devtools_manager_delegate.h"

6	6

7 #include "android_webview/browser/browser_view_renderer.h"	7 #include "android_webview/browser/browser_view_renderer.h"

8 #include "android_webview/common/aw_content_client.h"	8 #include "android_webview/common/aw_content_client.h"

9 #include "base/json/json_writer.h"	9 #include "base/json/json_writer.h"

10 #include "base/memory/ptr_util.h"	10 #include "base/memory/ptr_util.h"

11 #include "base/strings/stringprintf.h"	11 #include "base/strings/stringprintf.h"

12 #include "base/strings/utf_string_conversions.h"	12 #include "base/strings/utf_string_conversions.h"

13 #include "content/public/browser/devtools_agent_host.h"	13 #include "content/public/browser/devtools_agent_host.h"

14 #include "content/public/browser/web_contents.h"	14 #include "content/public/browser/web_contents.h"

15	15

16 using content::DevToolsAgentHost;	16 using content::DevToolsAgentHost;

17 using content::RenderFrameHost;	17 using content::RenderFrameHost;

18	18

19 namespace android_webview {	19 namespace android_webview {

20	20

21 AwDevToolsManagerDelegate::AwDevToolsManagerDelegate() {	21 AwDevToolsManagerDelegate::AwDevToolsManagerDelegate() {

22 }	22 }

23	23

24 AwDevToolsManagerDelegate::~AwDevToolsManagerDelegate() {	24 AwDevToolsManagerDelegate::~AwDevToolsManagerDelegate() {

25 }	25 }

26	26

27 void AwDevToolsManagerDelegate::Inspect(DevToolsAgentHost* agent_host) {

28 }

29

30 void AwDevToolsManagerDelegate::DevToolsAgentStateChanged(

31 DevToolsAgentHost* agent_host, bool attached) {

32 }

33

34 std::string AwDevToolsManagerDelegate::GetTargetDescription(	27 std::string AwDevToolsManagerDelegate::GetTargetDescription(

35 RenderFrameHost* host) {	28 RenderFrameHost* host) {

36 content::WebContents* web_contents =	29 content::WebContents* web_contents =

37 content::WebContents::FromRenderFrameHost(host);	30 content::WebContents::FromRenderFrameHost(host);

38 android_webview::BrowserViewRenderer* bvr =	31 android_webview::BrowserViewRenderer* bvr =

39 android_webview::BrowserViewRenderer::FromWebContents(web_contents);	32 android_webview::BrowserViewRenderer::FromWebContents(web_contents);

40 if (!bvr)	33 if (!bvr)

41 return "";	34 return "";

42 base::DictionaryValue description;	35 base::DictionaryValue description;

43 description.SetBoolean("attached", bvr->attached_to_window());	36 description.SetBoolean("attached", bvr->attached_to_window());

(...skipping 15 matching lines...) Expand all Loading...
59 const char html[] =	52 const char html[] =

60 "<html>"	53 "<html>"

61 "<head><title>WebView remote debugging</title></head>"	54 "<head><title>WebView remote debugging</title></head>"

62 "<body>Please use <a href=\'chrome://inspect\'>chrome://inspect</a>"	55 "<body>Please use <a href=\'chrome://inspect\'>chrome://inspect</a>"

63 "</body>"	56 "</body>"

64 "</html>";	57 "</html>";

65 return html;	58 return html;

66 }	59 }

67	60

68 } // namespace android_webview	61 } // namespace android_webview

OLD	NEW