Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: for landing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 */ 8 */
9 WebInspector.DevicesView = function() 9 WebInspector.DevicesView = function()
10 { 10 {
(...skipping 616 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 _updatePageSection: function(section, page) 627 _updatePageSection: function(section, page)
628 { 628 {
629 if (!section.page || section.page.name !== page.name) { 629 if (!section.page || section.page.name !== page.name) {
630 section.title.textContent = page.name; 630 section.title.textContent = page.name;
631 section.title.title = page.name; 631 section.title.title = page.name;
632 } 632 }
633 if (!section.page || section.page.url !== page.url) { 633 if (!section.page || section.page.url !== page.url) {
634 section.url.textContent = ""; 634 section.url.textContent = "";
635 section.url.appendChild(WebInspector.linkifyURLAsNode(page.url, unde fined, undefined, true)); 635 section.url.appendChild(WebInspector.linkifyURLAsNode(page.url, unde fined, undefined, true));
636 } 636 }
637 section.inspect.disabled = page.adbAttachedForeign; 637 section.inspect.disabled = page.attached;
638 638
639 section.page = page; 639 section.page = page;
640 }, 640 },
641 641
642 /** 642 /**
643 * @param {!Adb.DevicePortForwardingStatus} status 643 * @param {!Adb.DevicePortForwardingStatus} status
644 */ 644 */
645 portForwardingStatusChanged: function(status) 645 portForwardingStatusChanged: function(status)
646 { 646 {
647 var json = JSON.stringify(status); 647 var json = JSON.stringify(status);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 if (transient.length) 687 if (transient.length)
688 title.push(WebInspector.UIString("Transient: %s", transient.join(", "))); 688 title.push(WebInspector.UIString("Transient: %s", transient.join(", ")));
689 if (error.length) 689 if (error.length)
690 title.push(WebInspector.UIString("Error: %s", error.join(", "))); 690 title.push(WebInspector.UIString("Error: %s", error.join(", ")));
691 this._portStatus.title = title.join("; "); 691 this._portStatus.title = title.join("; ");
692 this._portStatus.classList.toggle("hidden", empty); 692 this._portStatus.classList.toggle("hidden", empty);
693 }, 693 },
694 694
695 __proto__: WebInspector.VBox.prototype 695 __proto__: WebInspector.VBox.prototype
696 } 696 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698