Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: test/cctest/test-modules.cc

Issue 2361593002: [modules] Do path resolution relative to each module file in d8 (Closed)
Patch Set: Review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-modules.cc
diff --git a/test/cctest/test-modules.cc b/test/cctest/test-modules.cc
index c74446bf18c7dc7add364db54a2c7830bff3efa3..c33a5a124b94e817e3c9ab816bb0b5934e2fd465 100644
--- a/test/cctest/test-modules.cc
+++ b/test/cctest/test-modules.cc
@@ -6,6 +6,8 @@
#include "test/cctest/cctest.h"
+namespace {
+
using v8::Context;
using v8::HandleScope;
using v8::Isolate;
@@ -17,17 +19,18 @@ using v8::ScriptOrigin;
using v8::String;
using v8::Value;
-static MaybeLocal<Module> AlwaysEmptyResolveCallback(Local<Context> context,
- Local<String> specifier,
- Local<Module> referrer,
- Local<Value> data) {
+MaybeLocal<Module> AlwaysEmptyResolveCallback(Local<Context> context,
+ Local<String> specifier,
+ Local<Module> referrer,
+ Local<Value> data) {
return MaybeLocal<Module>();
}
static int g_count = 0;
-static MaybeLocal<Module> FailOnSecondCallResolveCallback(
- Local<Context> context, Local<String> specifier, Local<Module> referrer,
- Local<Value> data) {
+MaybeLocal<Module> FailOnSecondCallResolveCallback(Local<Context> context,
+ Local<String> specifier,
+ Local<Module> referrer,
+ Local<Value> data) {
if (g_count++ > 0) return MaybeLocal<Module>();
Local<String> source_text = v8_str("");
ScriptOrigin origin(v8_str("module.js"));
@@ -89,3 +92,20 @@ TEST(ModuleEvaluation) {
CHECK(!module->Evaluate(env.local()).IsEmpty());
ExpectInt32("Object.expando", 10);
}
+
+TEST(EmbedderData) {
+ Isolate* isolate = CcTest::isolate();
+ HandleScope scope(isolate);
+ LocalContext env;
+
+ Local<String> source_text = v8_str("");
+ ScriptOrigin origin(v8_str("file.js"));
+ ScriptCompiler::Source source(source_text, origin);
+ Local<Module> module =
+ ScriptCompiler::CompileModule(isolate, &source).ToLocalChecked();
+ CHECK(module->GetEmbedderData()->IsUndefined());
+ module->SetEmbedderData(v8_num(42));
+ CHECK_EQ(42, Local<v8::Int32>::Cast(module->GetEmbedderData())->Value());
+}
+
+} // anonymous namespace
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698