appengine/findit/waterfall/build_util.py - Issue 2361583002: [Findit] UI change and triage change for cl level trige.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_util.py

Issue 2361583002: [Findit] UI change and triage change for cl level trige. (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/build_util.py

diff --git a/appengine/findit/waterfall/build_util.py b/appengine/findit/waterfall/build_util.py

index a04d66e1d8c1eabf6581a9ee97663488ad3e7f86..95c5c9f8150ec835ca4480163f350f48135e9635 100644

--- a/appengine/findit/waterfall/build_util.py

+++ b/appengine/findit/waterfall/build_util.py

@@ -61,7 +61,4 @@ def GetBuildEndTime(master_name, builder_name, build_number):

build = DownloadBuildData(master_name, builder_name, build_number)

build_info = buildbot.ExtractBuildInfo(

master_name, builder_name, build_number, build.data)

- return build_info.build_end_time

-def GetBuildKeyForBuildInfo(master_name, builder_name, build_number):

- return '%s/%s/%d' %(master_name, builder_name, build_number)

+ return build_info.build_end_time