Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: appengine/findit/templates/waterfall/compile_failure.html

Issue 2361583002: [Findit] UI change and triage change for cl level trige. (Closed)
Patch Set: fixes on result page. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends "build_failure.html" %} 1 {% extends "build_failure.html" %}
2 2
3 {% block title %}Compile{% endblock title %} 3 {% block title %}Compile{% endblock title %}
4 4
5 {% block style %} 5 {% block style %}
6 .warning { 6 .warning {
7 color: RED; 7 color: RED;
8 } 8 }
9 {% endblock style %} 9 {% endblock style %}
10 10
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 {% else %} 54 {% else %}
55 <div>No culprit found!</div> 55 <div>No culprit found!</div>
56 {% endif%} 56 {% endif%}
57 {% endif%} 57 {% endif%}
58 </div> 58 </div>
59 {% endif%} 59 {% endif%}
60 {% endblock try_job_result %} 60 {% endblock try_job_result %}
61 61
62 {% block result_tables %} 62 {% block result_tables %}
63 <div> 63 <div>
64 <b>Heuristic result:</b> 64 <b>Heuristic result:</b>
stgao 2016/09/23 19:35:41 Can we have a <br> between try-job result and heur
chanli 2016/09/24 01:09:40 Done.
65 {% if analysis_failed %} 65 {% if analysis_failed %}
66 <div class="error">No result because of some error in analysis!</div> 66 <div class="error">No result because of some error in analysis!</div>
67 {% elif suspected_cls_by_heuristic|length == 0 %} 67 {% elif suspected_cls_by_heuristic|length == 0 %}
68 <div>No culprit is found!</div> 68 <div>No culprit is found!</div>
69 {% else %} 69 {% else %}
70 <div id="suspected_cls"> 70 <div id="heuristic_result">
71 <table> 71 <table>
72 <tr> 72 <tr>
73 <th title="The build cycle in which the culprit was in">Build Number </th> 73 <th title="The build cycle in which the culprit was in">Build Number </th>
74 <th title="Git repo name and commit position/hash of the suspect">Su spect</th> 74 <th title="Git repo name and commit position/hash of the suspect">Su spect</th>
75 <th title="The higher score, the more suspected">Score(<a class="sco re-info" href="javascript:">?</a>)</th> 75 <th title="The higher score, the more suspected">Score(<a class="sco re-info" href="javascript:">?</a>)</th>
76 <th title="Why this CL is related to the failure">Hints</th> 76 <th title="Why this CL is related to the failure">Hints</th>
77 </tr> 77 </tr>
78 <tbody> 78 <tbody>
79 {% for suspected_cl in suspected_cls_by_heuristic %} 79 {% for suspected_cl in suspected_cls_by_heuristic %}
80 <tr> 80 <tr>
81 <td><a href="https://build.chromium.org/p/{{master_name}}/builders /{{builder_name}}/builds/{{suspected_cl.build_number}}">{{suspected_cl.build_num ber}}</a></td> 81 <td><a href="https://build.chromium.org/p/{{master_name}}/builders /{{builder_name}}/builds/{{suspected_cl.build_number}}">{{suspected_cl.build_num ber}}</a></td>
82 <td> 82 <td>
83 {{suspected_cl.repo_name}} <a href="{{suspected_cl.url}}">{{susp ected_cl.commit_position or suspected_cl.revision}}</a> 83 {{suspected_cl.repo_name}} <a href="{{suspected_cl.url}}">{{susp ected_cl.commit_position or suspected_cl.revision}}</a>
84 </td> 84 </td>
85 <td>{{suspected_cl.score}}</td> 85 <td>{{suspected_cl.score}}</td>
86 <td> 86 <td>
87 {% for hint, _ in suspected_cl.hints|dictsort(case_sensitive=Tru e, by='value')|reverse %} 87 {% for hint, _ in suspected_cl.hints|dictsort(case_sensitive=Tru e, by='value')|reverse %}
88 <li>{{hint}}</li> 88 <li>{{hint}}</li>
89 {% endfor %} 89 {% endfor %}
90 </td> 90 </td>
91 </tr> 91 </tr>
92 {% endfor %} 92 {% endfor %}
93 </tbody> 93 </tbody>
94 </table> 94 </table>
95 </div> 95 </div>
96 {% endif %} 96 {% endif %}
97 </div> 97 </div>
98 {% endblock result_tables %} 98 {% endblock result_tables %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698