[heap] Simplify incremental marking counters in GCTracer.

[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC cycle.

It also replaces the ring buffer of record incremental marking speeds with a single variable.

Committed: https://crrev.com/4c2fd5cd5fcf14a0e522b08ba32046b289102bf5
Cr-Commit-Position: refs/heads/master@{#39826}

[ulan, 2016-09-23 10:23:30]

Description was changed from

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with ordinary counters.
==========

to

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC
cycle.

It also replaces the ring buffer of record incremental marking speeds with a
single variable.
==========

[ulan, 2016-09-26 08:53:13]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-09-26 08:53:14]

ptal

[Michael Lippautz, 2016-09-26 11:07:28]

lgtm

https://codereview.chromium.org/2361563004/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2361563004/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:271: DCHECK(current_.incremental_marking_bytes == 0);
nit: DCHECK_EQ

[ulan, 2016-09-27 15:42:21]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-09-27 15:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-27 15:43:26]

The CQ bit was unchecked by ulan@chromium.org

[ulan, 2016-09-27 15:46:02]

https://codereview.chromium.org/2361563004/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2361563004/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:271: DCHECK(current_.incremental_marking_bytes == 0);
On 2016/09/26 11:07:28, Michael Lippautz wrote:
> nit: DCHECK_EQ

Done.

[ulan, 2016-09-27 15:46:06]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-27 15:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2361563004/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2016-09-27 15:46:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-27 15:46:14]

The CQ bit was unchecked by ulan@chromium.org

[ulan, 2016-09-27 15:46:39]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-27 15:46:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2361563004/#ps60001
(title: "correct rebase")

[commit-bot: I haz the power, 2016-09-27 15:46:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 17:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:43:33]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[ulan, 2016-09-27 17:58:44]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:40:40]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[ulan, 2016-09-28 08:15:43]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-09-28 08:15:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-28 09:56:04]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-28 09:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2361563004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-28 09:56:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-28 11:17:50]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-28 11:17:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2361563004/#ps100001
(title: "Fix corner case")

[commit-bot: I haz the power, 2016-09-28 11:18:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2016-09-28 11:19:47]

still lgtm

[commit-bot: I haz the power, 2016-09-28 11:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 11:33:41]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ulan, 2016-09-28 12:32:02]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-28 12:32:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2361563004/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2016-09-28 12:32:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 12:58:14]

Description was changed from

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC
cycle.

It also replaces the ring buffer of record incremental marking speeds with a
single variable.
==========

to

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC
cycle.

It also replaces the ring buffer of record incremental marking speeds with a
single variable.
==========

[commit-bot: I haz the power, 2016-09-28 12:58:15]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-28 12:58:27]

Description was changed from

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC
cycle.

It also replaces the ring buffer of record incremental marking speeds with a
single variable.
==========

to

==========
[heap] Simplify incremental marking counters in GCTracer.

This patch replaces cumulative counters with the counters for the current GC
cycle.

It also replaces the ring buffer of record incremental marking speeds with a
single variable.

Committed: https://crrev.com/4c2fd5cd5fcf14a0e522b08ba32046b289102bf5
Cr-Commit-Position: refs/heads/master@{#39826}
==========

[commit-bot: I haz the power, 2016-09-28 12:58:28]

Patchset 7 (id:??) landed as
https://crrev.com/4c2fd5cd5fcf14a0e522b08ba32046b289102bf5
Cr-Commit-Position: refs/heads/master@{#39826}