Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2361563002: chromeos: Laser tool blocks events from propagating. (Closed)

Created:
4 years, 3 months ago by jdufault
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

chromeos: Laser tool blocks events from propagating. After discussion concluded the best way was to delegate the laser pointer out of ash/common. Moved all the laser related files into ash/laser. LaserPointerController.* replaces LaserPointerMode.* and it inherits from EventHandler to grab the events and propagate them to LaserPointerView/LaserPointerPoints, which remain the same. LaserPointerMode just inherits common palette tool and calls the delegate. BUG=644804 TEST=ash_unittests --gtest_filter="LaserPointer*" https://screenshot.googleplex.com/BtwX1GTCpcW Review-Url: https://codereview.chromium.org/2311393004 Cr-Commit-Position: refs/heads/master@{#419400} (cherry picked from commit 203ae0296e08db2452a4558d3e84dcf713f6badf) Committed: https://chromium.googlesource.com/chromium/src/+/a7c7f28d53e55047046c1f985885433486150abc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -913 lines) Patch
M ash/BUILD.gn View 4 chunks +23 lines, -2 lines 0 comments Download
M ash/ash.gyp View 4 chunks +0 lines, -12 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/common/palette_delegate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/palette/tools/laser_pointer_mode.h View 2 chunks +2 lines, -28 lines 0 comments Download
M ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc View 3 chunks +3 lines, -64 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_mode_test_api.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_points.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_points.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_points_test_api.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_points_test_api.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_view.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ash/common/system/chromeos/palette/tools/laser_pointer_view.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M ash/common/test/test_palette_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/test/test_palette_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/wm_shell.h View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/laser/laser_pointer_controller.h View 1 chunk +76 lines, -0 lines 0 comments Download
A ash/laser/laser_pointer_controller.cc View 1 chunk +140 lines, -0 lines 0 comments Download
A ash/laser/laser_pointer_controller_test_api.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ash/laser/laser_pointer_controller_test_api.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A + ash/laser/laser_pointer_controller_unittest.cc View 4 chunks +79 lines, -65 lines 0 comments Download
A + ash/laser/laser_pointer_points.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/laser/laser_pointer_points.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/laser/laser_pointer_points_test_api.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + ash/laser/laser_pointer_points_test_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + ash/laser/laser_pointer_view.h View 3 chunks +14 lines, -6 lines 0 comments Download
A + ash/laser/laser_pointer_view.cc View 7 chunks +40 lines, -12 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 5 chunks +5 lines, -16 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell.h View 5 chunks +11 lines, -6 lines 0 comments Download
M ash/shell.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
4 years, 3 months ago (2016-09-21 20:03:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7c7f28d53e55047046c1f985885433486150abc.

Powered by Google App Engine
This is Rietveld 408576698