Pressure should not be set when the pointer device doesn't support pressure

Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/EventOverview/EventObjectsTypes/EventObjectsTypes.html#//apple_ref/doc/uid/10000060i-CH4-SW4

BUG=648375
Committed: https://crrev.com/d0d3d88e1c94e01fb14ecdb3a11f786859236d5b
Cr-Commit-Position: refs/heads/master@{#420161}

[lanwei, 2016-09-21 19:09:31]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:09:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2016-09-21 19:13:45]

Description was changed from

==========
mac pointe pressure


mac pointe pressure

BUG=
==========

to

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

BUG=648375
==========

[lanwei, 2016-09-21 19:13:45]

lanwei@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[lanwei, 2016-09-21 19:16:01]

Description was changed from

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

BUG=648375
==========

to

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of
NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Ev...

BUG=648375
==========

[dtapuska, 2016-09-21 19:26:24]

lgtm

[commit-bot: I haz the power, 2016-09-21 19:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:34:24]

Dry run: This issue passed the CQ dry run.

[mustaq, 2016-09-21 19:39:37]

https://codereview.chromium.org/2361523002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2361523002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:411: return
result;
- Could you please confirm that uninitialized result.force gets a NaN value here
as opposed to 0 or random? For result.tiltX/Y, uninitialized values are always
0, right?

- You are now setting the value by relying on pointerType. Is there a way to
query the device if pressure is supported or not? If not sure, please add a
TODO.

[lanwei, 2016-09-21 20:13:42]

https://codereview.chromium.org/2361523002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/web_input_event_builders_mac.mm
(right):

https://codereview.chromium.org/2361523002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/web_input_event_builders_mac.mm:411: return
result;
On 2016/09/21 19:39:36, mustaq wrote:
> - Could you please confirm that uninitialized result.force gets a NaN value
here
> as opposed to 0 or random? For result.tiltX/Y, uninitialized values are always
> 0, right?
> 
> - You are now setting the value by relying on pointerType. Is there a way to
> query the device if pressure is supported or not? If not sure, please add a
> TODO.

Yes, default values of force is NaN, tiltx, y are 0,
https://codesearch.chromium.org/chromium/src/third_party/WebKit/public/platfo...

There is no way to query a specific property, in their spec, they said we can
use the subtype to decide if the event is 'pointer events', the event that a
tablet device generates after a stylus has entered proximity of the tablet, the
pressure, rotation, tilt are defined under this event.

[mustaq, 2016-09-21 20:41:32]

lgtm

[lanwei, 2016-09-21 20:51:08]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:51:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:57:22]

Description was changed from

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of
NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Ev...

BUG=648375
==========

to

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of
NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Ev...

BUG=648375
==========

[commit-bot: I haz the power, 2016-09-21 20:57:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 21:00:22]

Description was changed from

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of
NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Ev...

BUG=648375
==========

to

==========
Pressure should not be set when the pointer device doesn't support pressure.

When pointer events have a pointer type of mouse, we should not set their
pressure,
the default value is 0.5 according to the spec.

In Cocoa Event doc, the pressure is only set for events with a subtype of
NSTabletPointEventSubtype.
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Ev...

BUG=648375

Committed: https://crrev.com/d0d3d88e1c94e01fb14ecdb3a11f786859236d5b
Cr-Commit-Position: refs/heads/master@{#420161}
==========

[commit-bot: I haz the power, 2016-09-21 21:00:23]

Patchset 1 (id:??) landed as
https://crrev.com/d0d3d88e1c94e01fb14ecdb3a11f786859236d5b
Cr-Commit-Position: refs/heads/master@{#420161}