Revert r16548 due to cpu profiler test falkiness

src/cpu-profiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 86 matching lines @@
 #undef PROFILER_TYPE_CASE
       default: return true;  // Skip record.
     }
     last_processed_code_event_id_ = record.generic.order;
     return true;
   }
   return false;
 }
 
 
-bool ProfilerEventsProcessor::ProcessOneSample() {
-  if (!ticks_from_vm_buffer_.IsEmpty()
-      && ticks_from_vm_buffer_.Peek()->order ==
-         last_processed_code_event_id_) {
-    TickSampleEventRecord record;
-    ticks_from_vm_buffer_.Dequeue(&record);
-    generator_->RecordTickSample(record.sample);
-    return false;
+bool ProfilerEventsProcessor::ProcessTicks() {
+  while (true) {
+    while (!ticks_from_vm_buffer_.IsEmpty()
+        && ticks_from_vm_buffer_.Peek()->order ==
+           last_processed_code_event_id_) {
+      TickSampleEventRecord record;
+      ticks_from_vm_buffer_.Dequeue(&record);
+      generator_->RecordTickSample(record.sample);
+    }
+
+    const TickSampleEventRecord* record = ticks_buffer_.Peek();
+    if (record == NULL) return !ticks_from_vm_buffer_.IsEmpty();
+    if (record->order != last_processed_code_event_id_) return true;
+    generator_->RecordTickSample(record->sample);
+    ticks_buffer_.Remove();
   }
+}
 
-  const TickSampleEventRecord* record = ticks_buffer_.Peek();
-  if (record == NULL) return true;
-  if (record->order != last_processed_code_event_id_) return true;
-  generator_->RecordTickSample(record->sample);
-  ticks_buffer_.Remove();
-  return false;
+
+void ProfilerEventsProcessor::ProcessEventsAndDoSample() {
+  ElapsedTimer timer;
+  timer.Start();
+  // Keep processing existing events until we need to do next sample.
+  while (!timer.HasExpired(period_)) {
+    if (ProcessTicks()) {
+      // All ticks of the current dequeue_order are processed,
+      // proceed to the next code event.
+      ProcessCodeEvent();
+    }
+  }
+  // Schedule next sample. sampler_ is NULL in tests.
+  if (sampler_) sampler_->DoSample();
 }
 
 
 void ProfilerEventsProcessor::Run() {
   while (running_) {
-    ElapsedTimer timer;
-    timer.Start();
-    // Keep processing existing events until we need to do next sample.
-    do {
-      if (ProcessOneSample()) {
-        // All ticks of the current last_processed_code_event_id_ are
-        // processed, proceed to the next code event.
-        ProcessCodeEvent();
-      }
-    } while (!timer.HasExpired(period_));
-
-    // Schedule next sample. sampler_ is NULL in tests.
-    if (sampler_) sampler_->DoSample();
+    ProcessEventsAndDoSample();
   }
 
   // Process remaining tick events.
   do {
-    while (!ProcessOneSample()) {}
+    ProcessTicks();
   } while (ProcessCodeEvent());
 }
 
 
 int CpuProfiler::GetProfilesCount() {
   // The count of profiles doesn't depend on a security token.
   return profiles_->profiles()->length();
 }
 
 
@@ skipping 333 matching lines @@
     ReportBuiltinEventRecord* rec = &evt_rec.ReportBuiltinEventRecord_;
     Builtins::Name id = static_cast<Builtins::Name>(i);
     rec->start = builtins->builtin(id)->address();
     rec->builtin_id = id;
     processor_->Enqueue(evt_rec);
   }
 }
 
 
 } }  // namespace v8::internal