content/browser/nav_controller/nav_controller_context.cc - Issue 23615009: Stub out initial NavigationController browser implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/nav_controller/nav_controller_context.cc

Issue 23615009: Stub out initial NavigationController browser implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments, s/peer/registry/ now that blink side is settled Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/nav_controller/nav_controller_context.h"

	6

	7 #include "base/files/file_path.h"

	8 #include "webkit/browser/quota/quota_manager.h"

	9

	10 namespace content {

	11

	12 const base::FilePath::CharType kNavControllerDirectory[] =

	13 FILE_PATH_LITERAL("NavController");

	14

	15 NavControllerContext::NavControllerContext(

	16 const base::FilePath& path,
	Tom Sepez 2013/09/13 21:48:34 Who gets to specify this path? Hardcoded in browse Who gets to specify this path? Hardcoded in browser? Sent by renderer? How do we know that it is legal to write here ... a path with ../../.. in it would be bad.
	17 quota::QuotaManagerProxy* quota_manager_proxy)

	18 : quota_manager_proxy_(quota_manager_proxy) {

	19 if (!path.empty())

	20 path_ = path.Append(kNavControllerDirectory);

	21 }

	22

	23 NavControllerContext::~NavControllerContext() {}

	24

	25 } // namespace content

OLD	NEW