Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: cc/tiles/gpu_image_decode_controller.cc

Issue 2361493005: Remove warning DCHECK from GPU Image Decode Controller (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/gpu_image_decode_controller.cc
diff --git a/cc/tiles/gpu_image_decode_controller.cc b/cc/tiles/gpu_image_decode_controller.cc
index 83ce4c4cf1c4677c5945f3d228bdb12b3e03dd28..50e3674782d0dd3a42e221b76d5178878d0131d0 100644
--- a/cc/tiles/gpu_image_decode_controller.cc
+++ b/cc/tiles/gpu_image_decode_controller.cc
@@ -973,12 +973,9 @@ void GpuImageDecodeController::DecodeImageIfNecessary(
break;
}
case DecodedDataMode::GPU: {
- // Params should not have changed since initial sizing.
- DCHECK(image_data->upload_params.fMatrix == draw_image.matrix());
- DCHECK_EQ(image_data->upload_params.fPreScaleMipLevel,
- CalculateUploadScaleMipLevel(draw_image));
- DCHECK_EQ(image_data->upload_params.fQuality,
- CalculateUploadScaleFilterQuality(draw_image));
+ // TODO(crbug.com/649167): Params should not have changed since initial
+ // sizing. Somehow this still happens. We should investigate and re-add
+ // DCHECKs here to enforce this.
if (!draw_image.image()->getDeferredTextureImageData(
*context_threadsafe_proxy_.get(), &image_data->upload_params, 1,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698