Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2361493005: Remove warning DCHECK from GPU Image Decode Controller (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
cblume
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove warning DCHECK from GPU Image Decode Controller When uploading an image, the DeferredTextureImageUsageParams should not have changed from initial sizing time. Somehow this can happen. This is not a correctness error, but a slight perf issue, as it will cause us to lazy generate mips as opposed to doing so asynchronously. We should fix this issue and re-add the DCHECKs to enforce this, but until we are able to, remove the DCHECK. BUG=649167 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1299d0c91e5943e7ebc689d3770793180fa0b1af Cr-Commit-Position: refs/heads/master@{#420685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M cc/tiles/gpu_image_decode_controller.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ericrk
4 years, 3 months ago (2016-09-23 00:02:56 UTC) #3
cblume
LGTM
4 years, 3 months ago (2016-09-23 17:33:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361493005/1
4 years, 3 months ago (2016-09-23 17:39:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 19:03:49 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:07:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1299d0c91e5943e7ebc689d3770793180fa0b1af
Cr-Commit-Position: refs/heads/master@{#420685}

Powered by Google App Engine
This is Rietveld 408576698