Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2361473002: Always use transfer_dst for buffers. (Closed)

Created:
4 years, 3 months ago by jvanverth1
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Always use transfer_dst for buffers. This will allow Adreno to use non-coherent buffers. BUG=skia:5034 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361473002 Committed: https://skia.googlesource.com/skia/+/7d05f32a1dec990321ffd8165d5f253ab99de3e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
Not seeing a lot of perf gain, but it probably doesn't hurt to have it.
4 years, 3 months ago (2016-09-21 15:51:00 UTC) #3
egdaniel
lgtm
4 years, 3 months ago (2016-09-21 16:02:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361473002/1
4 years, 3 months ago (2016-09-21 16:46:13 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:20:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7d05f32a1dec990321ffd8165d5f253ab99de3e5

Powered by Google App Engine
This is Rietveld 408576698