Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2361443002: Revert of Roll clang 280836:281889. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 280836:281889. (patchset #1 id:1 of https://codereview.chromium.org/2349183003/ ) Reason for revert: Broke android builds, see https://crbug.com/648800 Original issue's description: > Roll clang 280836:281889. > > * plugin/win: Use absolute path of source file for filtering > * win: more debug info types > * fix for a perf regression > * win: support for more intrinsics as intrinsics > * win: don't allow duplicate uuid attributes > * win: don't inline implicit ctors, dtors in dllimported classes > * linux: link clang against libstdc++ 4.8.5 instead of 4.8.2 > * mac: bundle iOS compiler-rt libs (libclang_rt.profile_ios.a , libclang_rt.asan_iossim_dynamic.dylib) > > Ran `tools/clang/scripts/upload_revision.py 281889`. > > BUG=645953 > TBR=hans > > Committed: https://crrev.com/4143619d2f58609282b29d102a0c274ffe5910df > Cr-Commit-Position: refs/heads/master@{#419767} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645953 Committed: https://crrev.com/c460f170ff1b75bc4f7db11e8b88177b785b18c2 Cr-Commit-Position: refs/heads/master@{#420055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Roll clang 280836:281889.
4 years, 3 months ago (2016-09-21 14:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361443002/1
4 years, 3 months ago (2016-09-21 14:56:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 14:57:01 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:59:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c460f170ff1b75bc4f7db11e8b88177b785b18c2
Cr-Commit-Position: refs/heads/master@{#420055}

Powered by Google App Engine
This is Rietveld 408576698