Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 2361413002: Obliterate legacy cronet API. All of its users have been migrated. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
index 55bb669a4533d577e9cc1e6155183aa7dfe494fd..7639ca72425ed835a7cf0c400eb09d305f2bbc63 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
@@ -6,7 +6,6 @@ package org.chromium.net;
import android.os.ConditionVariable;
import android.test.suitebuilder.annotation.LargeTest;
-import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.Log;
import org.chromium.base.annotations.SuppressFBWarnings;
@@ -18,7 +17,6 @@ import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
-import java.util.HashMap;
import java.util.concurrent.Executors;
/**
@@ -68,34 +66,6 @@ public class QuicTest extends CronetTestBase {
super.tearDown();
}
- @SmallTest
- @Feature({"Cronet"})
- @SuppressWarnings("deprecation")
- @OnlyRunNativeCronet
- public void testQuicLoadUrl_LegacyAPI() throws Exception {
- String[] commandLineArgs = {
- CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.LEGACY};
- mTestFramework = new CronetTestFramework(null, commandLineArgs, getContext(), mBuilder);
- String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
-
- HashMap<String, String> headers = new HashMap<String, String>();
- TestHttpUrlRequestListener listener = new TestHttpUrlRequestListener();
-
- // Although the native stack races QUIC and SPDY for the first request,
- // since there is no http server running on the corresponding TCP port,
- // QUIC will always succeed with a 200 (see
- // net::HttpStreamFactoryImpl::Request::OnStreamFailed).
- HttpUrlRequest request = mTestFramework.mRequestFactory.createRequest(
- quicURL, HttpUrlRequest.REQUEST_PRIORITY_MEDIUM, headers, listener);
- request.start();
- listener.blockForComplete();
- assertEquals(200, listener.mHttpStatusCode);
- assertEquals(
- "This is a simple text file served by QUIC.\n",
- listener.mResponseAsString);
- assertEquals("quic/1+spdy/3", listener.mNegotiatedProtocol);
- }
-
@LargeTest
@Feature({"Cronet"})
@OnlyRunNativeCronet

Powered by Google App Engine
This is Rietveld 408576698