Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2361413002: Obliterate legacy cronet API. All of its users have been migrated. (Closed)

Created:
4 years, 3 months ago by Charles
Modified:
4 years, 3 months ago
Reviewers:
kapishnikov, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, dplotnikov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Obliterate legacy cronet API. All of its users have been migrated. Committed: https://crrev.com/f62a203e0c8926aa7975f004b354837a351221c2 Cr-Commit-Position: refs/heads/master@{#420716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5314 lines) Patch
M components/cronet/android/BUILD.gn View 8 chunks +0 lines, -28 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/ChunkedWritableByteChannel.java View 1 chunk +0 lines, -126 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequest.java View 1 chunk +0 lines, -530 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java View 1 chunk +0 lines, -74 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlRequest.java View 1 chunk +0 lines, -178 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlRequestFactory.java View 1 chunk +0 lines, -107 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/HttpUrlRequestListener.java View 1 chunk +0 lines, -28 lines 0 comments Download
D components/cronet/android/api/src/org/chromium/net/ResponseTooLargeException.java View 1 chunk +0 lines, -20 lines 0 comments Download
M components/cronet/android/chromium_url_request.h View 1 chunk +0 lines, -2 lines 0 comments Download
D components/cronet/android/chromium_url_request.cc View 1 chunk +0 lines, -432 lines 0 comments Download
D components/cronet/android/chromium_url_request_context.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/cronet/android/chromium_url_request_context.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M components/cronet/android/cronet_library_loader.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D components/cronet/android/java/src/org/chromium/net/impl/ChromiumUrlRequest.java View 1 chunk +0 lines, -750 lines 0 comments Download
D components/cronet/android/java/src/org/chromium/net/impl/ChromiumUrlRequestContext.java View 1 chunk +0 lines, -159 lines 0 comments Download
D components/cronet/android/java/src/org/chromium/net/impl/ChromiumUrlRequestFactory.java View 1 chunk +0 lines, -76 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java View 1 chunk +0 lines, -304 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/ContextInitTest.java View 1 chunk +0 lines, -167 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 1 chunk +0 lines, -12 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java View 1 chunk +0 lines, -180 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java View 1 chunk +0 lines, -197 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 3 chunks +0 lines, -30 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java View 10 chunks +10 lines, -110 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/TestHttpUrlRequestListener.java View 1 chunk +0 lines, -90 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java View 1 chunk +0 lines, -349 lines 0 comments Download
M components/cronet/android/test/sdch_test_util.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java View 8 chunks +0 lines, -87 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/SdchObserver.java View 2 chunks +2 lines, -8 lines 0 comments Download
D components/cronet/android/url_request_adapter.h View 1 chunk +0 lines, -179 lines 0 comments Download
D components/cronet/android/url_request_adapter.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D components/cronet/android/url_request_context_adapter.h View 1 chunk +0 lines, -122 lines 0 comments Download
D components/cronet/android/url_request_context_adapter.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D components/cronet/android/wrapped_channel_upload_element_reader.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/cronet/android/wrapped_channel_upload_element_reader.cc View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Charles
PTAL
4 years, 3 months ago (2016-09-23 15:11:31 UTC) #3
mef
Nice! Andrei has removal of legacy API as part of builder API changes CL, so ...
4 years, 3 months ago (2016-09-23 16:25:19 UTC) #5
kapishnikov
On 2016/09/23 15:11:31, Charles wrote: > PTAL Charles here is the pending CL that also ...
4 years, 3 months ago (2016-09-23 17:34:43 UTC) #6
Charles
On 2016/09/23 17:34:43, kapishnikov wrote: > On 2016/09/23 15:11:31, Charles wrote: > > PTAL > ...
4 years, 3 months ago (2016-09-23 17:41:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361413002/1
4 years, 3 months ago (2016-09-23 17:43:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 20:30:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 20:32:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f62a203e0c8926aa7975f004b354837a351221c2
Cr-Commit-Position: refs/heads/master@{#420716}

Powered by Google App Engine
This is Rietveld 408576698