Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23614009: Rename websockets/*_unittest.cc to *_test.cc (Closed)

Created:
7 years, 3 months ago by Adam Rice
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename websockets/*_unittest.cc to *_test.cc The style guide says that the _test suffix should be used for tests, and the _unittest suffix is deprecated. Rename all the src/net/websockets test files to match. BUG=280943 TEST=net_unittests --gtest_filter="WebSocket*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3369 lines) Patch
M net/net.gyp View 1 chunk +8 lines, -8 lines 0 comments Download
M net/websockets/README View 2 chunks +8 lines, -9 lines 0 comments Download
A + net/websockets/websocket_errors_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_errors_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A + net/websockets/websocket_frame_parser_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_frame_parser_unittest.cc View 1 chunk +0 lines, -576 lines 0 comments Download
A + net/websockets/websocket_frame_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_frame_unittest.cc View 1 chunk +0 lines, -462 lines 0 comments Download
A + net/websockets/websocket_handshake_handler_spdy_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_handshake_handler_spdy_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
A + net/websockets/websocket_handshake_handler_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_handshake_handler_unittest.cc View 1 chunk +0 lines, -583 lines 0 comments Download
A + net/websockets/websocket_job_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_job_unittest.cc View 1 chunk +0 lines, -1112 lines 0 comments Download
A + net/websockets/websocket_net_log_params_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_net_log_params_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A + net/websockets/websocket_throttle_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/websockets/websocket_throttle_unittest.cc View 1 chunk +0 lines, -357 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Adam Rice
7 years, 3 months ago (2013-08-29 05:26:22 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
7 years, 3 months ago (2013-08-29 06:36:17 UTC) #2
yhirano
lgtm
7 years, 3 months ago (2013-08-29 06:54:00 UTC) #3
Adam Rice
+szym for net review.
7 years, 3 months ago (2013-08-29 07:03:54 UTC) #4
szym
lgtm, sorry I missed this review
7 years, 3 months ago (2013-09-06 08:41:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/23614009/1
7 years, 3 months ago (2013-09-06 11:32:04 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 14:36:47 UTC) #7
Message was sent while issue was closed. 
Change committed as 221708

Powered by Google App Engine
This is Rietveld 408576698