Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2361393005: Reland of [fullcodegen] Refactor code that calls store ICs. (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [fullcodegen] Refactor code that calls store ICs. (patchset #1 id:1 of https://codereview.chromium.org/2363123002/ ) Reason for revert: Didn't help Original issue's description: > Revert of [fullcodegen] Refactor code that calls store ICs. (patchset #1 id:20001 of https://codereview.chromium.org/2363513003/ ) > > Reason for revert: > race suspect: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 > > Original issue's description: > > [fullcodegen] Refactor code that calls store ICs. > > > > Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load > > slot according to store IC calling convention (StoreDescriptor). > > > > BUG=v8:5407 > > > > Committed: https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b > > Cr-Commit-Position: refs/heads/master@{#39679} > > TBR=mvstanton@chromium.org,ishell@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5407 > > Committed: https://crrev.com/51fa56d1b8e9e320f7442682415e9df50ab19591 > Cr-Commit-Position: refs/heads/master@{#39682} TBR=mvstanton@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5407 Committed: https://crrev.com/f1e418e8f6c59ee56f8f18818251ad9a5aa088ff Cr-Commit-Position: refs/heads/master@{#39683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -321 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +7 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 3 chunks +25 lines, -15 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 11 chunks +11 lines, -33 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 11 chunks +11 lines, -34 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 11 chunks +11 lines, -33 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 11 chunks +11 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Reland of [fullcodegen] Refactor code that calls store ICs.
4 years, 3 months ago (2016-09-23 17:31:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361393005/1
4 years, 3 months ago (2016-09-23 17:31:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 17:32:05 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:32:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1e418e8f6c59ee56f8f18818251ad9a5aa088ff
Cr-Commit-Position: refs/heads/master@{#39683}

Powered by Google App Engine
This is Rietveld 408576698